Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search program directory for config as fallback #463

Merged
merged 1 commit into from
May 22, 2019
Merged

Search program directory for config as fallback #463

merged 1 commit into from
May 22, 2019

Conversation

jterry75
Copy link
Contributor

Causes crictl to search its own directory for crictl.yaml if the user
does not specify a config path, and the default global path does not
exist.

Signed-off-by: Kevin Parsons [email protected]
Signed-off-by: Justin Terry (VM) [email protected]

@kevpar
Search program directory for config as fallback
a03b005 
Causes crictl to search its own directory for crictl.yaml if the user
does not specify a config path, and the default global path does not
exist.

Signed-off-by: Kevin Parsons <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 14, 2019
@k8s-ci-robot k8s-ci-robot requested review from runcom and yujuhong May 14, 2019 19:52
@jterry75
Copy link
Contributor Author

@kevpar - FYI

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2019
@jterry75
Copy link
Contributor Author

@feiskyer - PTAL when you get a chance.

@feiskyer
Copy link
Member

lgtm. @kevpar Could you sign the CLA?

@jterry75
Copy link
Contributor Author

@yujuhong - I was carrying this for @kevpar to avoid CLA since I am already a member and the commit has signoff by me as well. Does he have to sign the CLA as well?

@feiskyer
Copy link
Member

the commit is from him, so I think it's still required to pass the CLA check.

@feiskyer
Copy link
Member

/check-cla

@kevpar
Copy link
Contributor

kevpar commented May 21, 2019

I have signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 21, 2019
feiskyer
feiskyer reviewed May 22, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, jterry75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit a7c9d2a into kubernetes-sigs:master May 22, 2019
@jterry75
Copy link
Contributor Author

Thanks!

@jterry75 jterry75 deleted the config-fallback-path branch May 22, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@runcom runcom Awaiting requested review from runcom

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jterry75 @k8s-ci-robot @feiskyer @kevpar